search

manifoldco / promptui

Interactive prompt for command-line applications
https://www.manifold.co
BSD 3-Clause "New" or "Revised" License
6.03k stars 333 forks source link

Set custom stdio for Prompt #125

Closed preethamrn closed 4 years ago

preethamrn commented 4 years ago

This PR allows stdin and stdout to be configured for Prompt similar to how it is done in Select #112. This fixes issue #63.

codecov[bot] commented 4 years ago

Codecov Report

Merging #125 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   30.45%   30.45%           
=======================================
  Files           6        6           
  Lines         696      696           
=======================================
  Hits          212      212           
  Misses        463      463           
  Partials       21       21
Impacted Files Coverage Δ
prompt.go 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8fa33db...3a69e6b. Read the comment docs.

azzz commented 4 years ago

It would be great to merge this PR

preethamrn commented 4 years ago

@azzz Hi Yuriy. Do you know why the code coverage check is failing? As far as I can tell, I haven't updated any of the tests.

azzz commented 4 years ago

@preethamrn Hi. Oh, I have no idea. Looks like a glitch. What if you force-push the branch and re-trigger codecov?

azzz commented 4 years ago

Or maybe you should add a test for these changes.

jbowes commented 4 years ago

Thank you!