manifoldco / promptui

Interactive prompt for command-line applications
https://www.manifold.co
BSD 3-Clause "New" or "Revised" License
6.07k stars 336 forks source link

Remove gometalinter and add golangci-lint #128

Closed gssbzn closed 4 years ago

gssbzn commented 4 years ago

Since there's no progress going on #120 this tries to solve the same problem with a different approach

codecov[bot] commented 4 years ago

Codecov Report

Merging #128 into master will not change coverage. The diff coverage is 5.4%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #128   +/-   ##
=======================================
  Coverage   30.45%   30.45%           
=======================================
  Files           6        6           
  Lines         696      696           
=======================================
  Hits          212      212           
  Misses        463      463           
  Partials       21       21
Impacted Files Coverage Δ
screenbuf/screenbuf.go 60% <0%> (ø) :arrow_up:
prompt.go 0% <0%> (ø) :arrow_up:
select.go 17.24% <8.33%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8fa33db...bbfb055. Read the comment docs.

jbowes commented 4 years ago

Thanks @gssbzn, this is awesome.

I'm going to resolve the conflicts, and set up the golangci prefs to match what we at Manifold use internally, then push it to master.