manifoldfinance / fold-bpt-stake

MIT License
1 stars 0 forks source link

feat: swap, zap and stake rewards #21

Closed sandybradley closed 8 months ago

sandybradley commented 10 months ago
jeremyHD commented 10 months ago

harvest function would likely to be sandwiched. But it does happen to all harvest function on out there. The best we can do is to send via private pool

sandybradley commented 10 months ago

harvest function would likely to be sandwiched. But it does happen to all harvest function on out there. The best we can do is to send via private pool

Yeah, this is a risk worth noting for operations. Not sure what can be done about it at a solidity level as we are already using most liquid markets. On the plus side, in testing, the amounts of rewards aren't large enough to be sandwiched. Further, using gyro and curve v2 pools make sandwiching alot more difficult.