manifoldfinance / mevETH2

mevETH LST Protocol - Repo has migrated see link
https://github.com/MEV-Protocol/meveth
27 stars 2 forks source link

Evaluate Code Coverage (Revisit this issue with more specific places once evaluated) #1

Closed 0xKitsune closed 1 year ago

0xKitsune commented 1 year ago

Ensure (95% or higher) test coverage for the following contracts

sandybradley commented 1 year ago

We should define what we mean by coverage. There are 4 metrics on the report. Perhaps an avergae of Funcs, Lines and Statements.

Here's the report from the ci in withdrawal pr: File % Lines % Statements % Branches % Funcs
script/Deploy.s.sol 76.19% (16/21) 79.17% (19/24) 25.00% (1/4) 100.00% (1/1)
script/DeployOFT.s.sol 47.22% (17/36) 47.22% (17/36) 32.14% (9/28) 100.00% (1/1)
script/WireUpOFT.s.sol 0.00% (0/7) 0.00% (0/10) 0.00% (0/2) 0.00% (0/1)
src/MevEth.sol 98.73% (156/158) 93.66% (192/205) 79.17% (57/72) 97.37% (37/38)
src/MevEthRateProvider.sol 0.00% (0/1) 0.00% (0/2) 100.00% (0/0) 0.00% (0/1)
src/MevEthShareVault.sol 100.00% (28/28) 100.00% (32/32) 100.00% (4/4) 100.00% (9/9)
src/WagyuStaker.sol 71.43% (15/21) 72.73% (16/22) 33.33% (2/6) 83.33% (5/6)
src/layerZero/lzApp/LzApp.sol 30.77% (12/39) 31.15% (19/61) 30.00% (6/20) 17.65% (3/17)
src/layerZero/lzApp/NonblockingLzApp.sol 30.77% (4/13) 30.00% (6/20) 25.00% (2/8) 50.00% (2/4)
src/layerZero/oft/BaseOFTWithFee.sol 44.44% (4/9) 31.25% (5/16) 25.00% (1/4) 40.00% (2/5)
src/layerZero/oft/Fee.sol 84.21% (16/19) 68.18% (15/22) 66.67% (8/12) 80.00% (4/5)
src/layerZero/oft/OFTCoreV2.sol 35.80% (29/81) 38.26% (44/115) 25.00% (7/28) 52.63% (10/19)
src/layerZero/oft/OFTWithFee.sol 65.00% (13/20) 61.54% (16/26) 25.00% (2/8) 62.50% (5/8)
src/libraries/Auth.sol 100.00% (8/8) 100.00% (8/8) 100.00% (0/0) 100.00% (4/4)
src/util/BytesLib.sol 0.00% (0/20) 0.00% (0/32) 0.00% (0/12) 0.00% (0/5)
src/util/ExcessivelySafeCall.sol 0.00% (0/7) 0.00% (0/8) 0.00% (0/1) 0.00% (0/1)
test/MevEthTest.sol 0.00% (0/62) 0.00% (0/77) 100.00% (0/0) 0.00% (0/5)
test/mocks/DepositContract.sol 69.77% (30/43) 63.79% (37/58) 40.91% (9/22) 40.00% (2/5)
test/mocks/LZEndpointMock.sol 34.71% (42/121) 35.88% (61/170) 19.23% (10/52) 16.67% (6/36)
test/mocks/WETH9.sol 94.74% (18/19) 95.45% (21/22) 50.00% (4/8) 83.33% (5/6)
Total 55.66% (408/733) 52.59% (508/966) 41.92% (122/291) 54.24% (96/177)