Closed sandybradley closed 1 year ago
Imo we should wait until we get further along in MVP before looking at coverage
I would not trust Foundry's "coverage" at all to be honest. It has a few issues.
Vault and Admin have the highest tests so far.
What we should see is what we can accomplish and what should we ask hexens/auditors to write, this way we are not putting time and effort unnecessarily.
The testing suite currently has this listed (forge test -l)
Testing Suite:
test/Deploy.t.sol
DeployTest
testDeploy
test/attacks/ReentrancyAttack.sol
ReentrancyAttackTest
testAttack
test/unit/Admin.t.sol
MevAdminTest
testAddAdmin
testAddOperator
testCancelUpdateMevEthShareVault
testCancelUpdateStakingModule
testCommitUpdateMevEthShareVault
testCommitUpdateStakingModule
testDeleteAdmin
testDeleteOperator
testFinalizeUpdateMevEthShareVault
testFinalizeUpdateStakingModule
testInitMevEth
testNegativeAddAdmin
testNegativeAddOperator
testNegativeCancelCommitUpdateMevEthShareVault
testNegativeCancelCommitUpdateStakingModule
testNegativeCommitUpdateMevEthShareVault
testNegativeCommitUpdateStakingModule
testNegativeDeleteAdmin
testNegativeDeleteOperator
testNegativeFinalizeCommitUpdateMevEthShareVault
testNegativeFinalizeCommitUpdateStakingModule
testNegativeInitMevEth
testNegativePauseStaking
testNegativeRecoverTokenFromMevEthShareVault
testNegativeRecoverTokenFromStakingModule
testNegativeUnpauseStaking
testPauseStaking
testRecoverTokenFromMevEthShareVault
testRecoverTokenFromStakingModule
testUnpauseStaking
testUpdateToMevEthShareVault
test/unit/ERC4626.t.sol
ERC4626Test
testAsset
testBasicRedemption
testBasicWithdrawal
testCanRedeemWithApproval
testCanWithdrawWithApproval
testCannotWithdrawWithoutApproval
testDepositFailsBelowMinimum
testFuzzMaxMint
testFuzzMint
testFuzzRedeem
testFuzzSimpleDeposit
testMaxDeposit
testMaxRedeem
testMaxWithdraw
testNegativeMintBelowMinimum
testNegativeRedeemStealWithoutApproval
testPreviewDeposit
testPreviewMint
testPreviewRedeem
testPreviewWithdraw
testSimpleDeposit
testSimpleMint
test/unit/LayerZero.t.sol
LayerZeroTest
testSendFrom
test/unit/LayerZeroPigeon.t.sol
LayerZeroPigeonTest
testSendFromPigeon
test/unit/Rewards.t.sol
MevRewardsTest
testGrantRewards
testGrantRewardsFromMultisig
test/unit/Validator.t.sol
ValidatorTest
testCreateValidator
testNegativeCreateValidator
testUpdateToWagyuStakingModule
test/unit/ValidatorRefund.t.sol
MevValidatorRefundTest
testGrantValidatorWithdraw
Covered here: https://github.com/manifoldfinance/mevETH2/issues/1
Feature request
Reach 100 % test coverage for MevEth.
Coverage summary
Coverage debug
Uncovered for src/MevEth.sol:
Uncovered for src/MevEthRateProvider.sol:
Uncovered for src/MevEthShareVault.sol:
Uncovered for src/WagyuStaker.sol:
Anchors for Contract "WagyuStaker" (solc 0.8.20+commit.a1b79de6.Linux.gcc, source ID 25):
Anchors for Contract "MevEthShareVault" (solc 0.8.20+commit.a1b79de6.Linux.gcc, source ID 24):
Anchors for Contract "MevEth" (solc 0.8.20+commit.a1b79de6.Linux.gcc, source ID 22):
Anchors for Contract "MevETHRateProvider" (solc 0.8.20+commit.a1b79de6.Linux.gcc, source ID 23):