search

manifoldfinance / mevETH2

mevETH LST Protocol - Repo has migrated see link
https://github.com/MEV-Protocol/meveth
27 stars 2 forks source link

`createValidator` should emit an event #22

Closed mevpig closed 1 year ago

mevpig commented 1 year ago

Problem

Currently, there are no events being emitted, making it difficult for an off-chain app to keep tabs on when a validator was registered.

Solution

Emit an event.

ControlCplusControlV commented 1 year ago

Will do

sandybradley commented 1 year ago

Event is emiited via Staking Module: https://github.com/manifoldfinance/mevETH/blob/e32ac0072e56fe11f8a8c434a358e91e9691d2b0/src/WagyuStaker.sol#L51

We may want to move this into MevEth to make staking module upgrade independent of events.

ControlCplusControlV commented 1 year ago

We should probably emit an event from both places right? Would make it easier to track each componet