Fix Final Review Issues

manifoldfinance / mevETH2

mevETH LST Protocol - Repo has migrated see link

https://github.com/MEV-Protocol/meveth

27 stars 2 forks source link

Fix Final Review Issues #260

Closed ControlCplusControlV closed 11 months ago

ControlCplusControlV commented 11 months ago

Removes LayerZero OFT Code, discussed with @sambacha and @okkothejawa for security reasons
Adds 0 address check to address https://github.com/kebabsec/review-manifold/issues/20

sambacha commented 11 months ago

💯

ControlCplusControlV commented 11 months ago

Approve removal of OFT feature. Though I'm not happy about flip-flop decisions on this as it cost me a lot of time and energy to integrate it. I also thought it was a unique selling point.

Yeah I understand the frustration, I wish we could've decided on this sooner but the combination of changing business requirements + audit concerns removing it seems like the best option. That being said, we will definitely make use of this work when writing a l0 wrapper token for MevEth