search

manifoldfinance / mevETH2

mevETH LST Protocol - Repo has migrated see link
https://github.com/MEV-Protocol/meveth
27 stars 2 forks source link

adding/removing of admin/operator should emit events #42

Closed mevpig closed 1 year ago

mevpig commented 1 year ago

Is your feature request related to a problem? Please describe. At the moment, code in src/libraries/Auth.sol does not emit any events. This makes tracking of adding/removal of admins and operators quite tedious.

Describe the solution you'd like Events like OperatorAdded, AdminAdded, OperatorDeleted, AdminDeleted should be emitted at appropriate contract calls.

Describe alternatives you've considered Our controller app could figure out calling of the methods in the transaction, but for that we would need a facility that would be able list us all transactions that include this method. Events would make this way easier.

0xKitsune commented 1 year ago

Sounds good to me, I'll add this now.