Deposit minimum consensus

[sandybradley]

Problem

MevEth deposit minimum is currently hard coded as 1,000 wei. This should be parametrized and agreed upon. 0xBeans contract had the deposit minimum as 1,000,000,000,000,000,000 wei by comparison. https://github.com/manifoldfinance/mevETH/blob/1d28743e81f192fd31340ec8cc724c529847bfad/src/MevEth.sol#L287

Solution

Agree upon a value and implement with: DEPOSIT_MINIMUM constant / immutable / global set in MevEth. e.g.

// deposit minimum set at 0.001 eth (1,000,000,000,000,000 wei)
unit256 public constant DEPOSIT_MINIMUM = 1_000_000_000_000_000;

[ControlCplusControlV]

We discussed this at the call last week, we settled on a minimum deposit amount of 0.01 eth, or 10 finney (I think?)

[sambacha]

We discussed this at the call last week, we settled on a minimum deposit amount of 0.01 eth, or 10 finney (I think?)

to be sure ETH (wei, fei, etc) isn't a type, so the semantics:

• If the type of the right operand can be implicitly converted to the type of the left operand, use the type of the left operand,

• If the type of the left operand can be implicitly converted to the type of the right operand, use the type of the right operand,

• otherwise, the operation is not allowed.

cause it to inherit the smallest type.

e.g. a type of uint16 with max value 65535, 0.001 ether has no explicit type, the compiler will implicitly give it the smallest datatype it accepts i.e uint56 with a max value of 72057594037927935.