search

manifoldxyz / royalty-registry-client

39 stars 28 forks source link

String on ETH value input #7

Open evandroguedes opened 2 years ago

evandroguedes commented 2 years ago

Hi fellows,

I would like to contribute here and found a possible issue on the ETH value input (Lookup Bar).

I noticed that it's accepting any character in the end of the value:

Screen Shot 2022-03-14 at 9 09 51 PM Screen Shot 2022-03-14 at 9 00 02 PM

Is that the suppose way to work?

I can open a PR fix with unit tests, I just need to understand a little more about the needs. :)

wwhchung commented 2 years ago

Perfectly happy if you want to submit a code change restrciting eth input to numeric. :)

evandroguedes commented 2 years ago

Perfectly happy if you want to submit a code change restrciting eth input to numeric. :)

Awesome, I'll do. :)