make of r527 fails with Mozilla XULRunner 25.0.1

[GoogleCodeExporter]

uname -a
    Linux andromeda 3.7.10-1.16-desktop #1 SMP PREEMPT Fri May 31 20:21:23 UTC 2013 (97c14ba) x86_64 x86_64 x86_64 GNU/Linux

svn co http://gecko-mediaplayer.googlecode.com/svn/trunk/ gecko-mediaplayer
cd gecko-mediaplayer
svn log | head
    ------------------------------------------------------------------------
    r527 | kdekorte | 2013-09-16 13:04:30 -0700 (Mon, 16 Sep 2013) | 1 line

    v1.0.9a
    ------------------------------------------------------------------------
    r526 | kdekorte | 2013-08-02 05:50:05 -0700 (Fri, 02 Aug 2013) | 1 line

    Updated German translation
    ------------------------------------------------------------------------
    r525 | kdekorte | 2013-06-26 21:30:27 -0700 (Wed, 26 Jun 2013) | 1 line

/usr/local/xulrunner-sdk/bin/xulrunner --version
    Mozilla XULRunner 25.0.1 - 20131112160018

export CPPFLAGS="-I/usr/local/xulrunner-sdk/include -I/usr/include/nspr4"
./configure --with-xulrunner-sdk=/usr/local/xulrunner-sdk
make
    ...
    make  all-recursive
    make[1]: Entering directory `/usr/local/src/gecko-mediaplayer'
    Making all in src
    make[2]: Entering directory `/usr/local/src/gecko-mediaplayer/src'
    make[3]: Entering directory `/usr/local/src/gecko-mediaplayer/src'
      CXX      plugin_types_std.o
    plugin_types_std.cpp: In function ‘gchar* GetMIMEDescription()’:
    plugin_types_std.cpp:46:5: warning: ‘void g_type_init()’ is deprecated (declared at /usr/include/glib-2.0/gobject/gtype.h:669) [-Wdeprecated-declarations]
         g_type_init();
         ^
    plugin_types_std.cpp:46:17: warning: ‘void g_type_init()’ is deprecated (declared at /usr/include/glib-2.0/gobject/gtype.h:669) [-Wdeprecated-declarations]
         g_type_init();
                     ^
      CXX      plugin.o
    In file included from /usr/local/xulrunner-sdk/include/nsISupportsImpl.h:33:0,
                     from /usr/local/xulrunner-sdk/include/nsISupportsUtils.h:26,
                     from /usr/local/xulrunner-sdk/include/nsISupports.h:123,
                     from /usr/local/xulrunner-sdk/include/nsIPrefBranch.h:10,
                     from plugin.cpp:49:
    /usr/local/xulrunner-sdk/include/mozilla/Atomics.h:840:19: error: expected identifier before ‘sizeof’
         static_assert(sizeof(T) == 4 || (sizeof(uintptr_t) == 8 && sizeof(T) == 8),
                       ^
    /usr/local/xulrunner-sdk/include/mozilla/Atomics.h:840:19: error: expected ‘,’ or ‘...’ before ‘sizeof’
    /usr/local/xulrunner-sdk/include/mozilla/Atomics.h:841:83: error: ISO C++ forbids declaration of ‘static_assert’ with no type [-fpermissive]
                       "mozilla/Atomics.h only supports 32-bit and pointer-sized types");
                                                                                       ^
    plugin.cpp: In constructor ‘CPlugin::CPlugin(NPP)’:
    plugin.cpp:433:5: warning: ‘void g_type_init()’ is deprecated (declared at /usr/include/glib-2.0/gobject/gtype.h:669) [-Wdeprecated-declarations]
         g_type_init();
         ^
    plugin.cpp:433:17: warning: ‘void g_type_init()’ is deprecated (declared at /usr/include/glib-2.0/gobject/gtype.h:669) [-Wdeprecated-declarations]
         g_type_init();
                     ^
    plugin.cpp: In member function ‘NPError CPlugin::GetURLNotify(NPP, const char*, const char*, void*)’:
    plugin.cpp:1606:9: warning: ‘GThread* g_thread_create(GThreadFunc, gpointer, gboolean, GError**)’ is deprecated (declared at /usr/include/glib-2.0/glib/deprecated/gthread.h:100): Use 'g_thread_new' instead [-Wdeprecated-declarations]
             g_thread_create(CURLGetURLNotify, item, FALSE, NULL);
             ^
    plugin.cpp:1606:60: warning: ‘GThread* g_thread_create(GThreadFunc, gpointer, gboolean, GError**)’ is deprecated (declared at /usr/include/glib-2.0/glib/deprecated/gthread.h:100): Use 'g_thread_new' instead [-Wdeprecated-declarations]
             g_thread_create(CURLGetURLNotify, item, FALSE, NULL);
                                                                ^
    make[3]: *** [plugin.o] Error 1
    make[3]: Leaving directory `/usr/local/src/gecko-mediaplayer/src'
    make[2]: *** [all-recursive] Error 1
    make[2]: Leaving directory `/usr/local/src/gecko-mediaplayer/src'
    make[1]: *** [all-recursive] Error 1
    make[1]: Leaving directory `/usr/local/src/gecko-mediaplayer'
    make: *** [all] Error 2

Original issue reported on code.google.com by ops...@gmail.com on 15 Nov 2013 at 5:42

[GoogleCodeExporter]

Error appears to be within xulrunner, so open an issue with them.

In file included from /usr/local/xulrunner-sdk/include/nsISupportsImpl.h:33:0,
                     from /usr/local/xulrunner-sdk/include/nsISupportsUtils.h:26,
                     from /usr/local/xulrunner-sdk/include/nsISupports.h:123,
                     from /usr/local/xulrunner-sdk/include/nsIPrefBranch.h:10,
                     from plugin.cpp:49:
    /usr/local/xulrunner-sdk/include/mozilla/Atomics.h:840:19: error: expected identifier before ‘sizeof’
         static_assert(sizeof(T) == 4 || (sizeof(uintptr_t) == 8 && sizeof(T) == 8),
                       ^
    /usr/local/xulrunner-sdk/include/mozilla/Atomics.h:840:19: error: expected ‘,’ or ‘...’ before ‘sizeof’
    /usr/local/xulrunner-sdk/include/mozilla/Atomics.h:841:83: error: ISO C++ forbids declaration of ‘static_assert’ with no type [-fpermissive]
                       "mozilla/Atomics.h only supports 32-bit and pointer-sized types");
                                                                                       ^
    plugin.cpp: In constructor ‘CPlugin::CPlugin(NPP)’:

Original comment by kdeko...@gmail.com on 15 Nov 2013 at 1:47

• Changed state: WontFix

[GoogleCodeExporter]

Nope. There's no "error within xulrunner".

For xulrunner > v25.0, gcc with C++11 flags enabled is required.

For distro-provided GCC 4.8.2, that's done with

  CXXFLAGS="-std=gnu++0x"

at build time.

I.e., building gecko-mediaplayer with working xulrunner-sdk v>=25.0, and 
current distro-available GCC++'s that do not have C++11 compiled-in (few do 
...), that flag will have to be set for the build to succeed.

Either the user gets lucky and has a C++11-enabled compiler, or knows about 
this and sets it, or gecko-mediaplayer config need to test for and set it.

Original comment by ops...@gmail.com on 16 Nov 2013 at 2:34

[GoogleCodeExporter]

reference here:

https://groups.google.com/forum/#!topic/mozilla.dev.platform/1Ba97-ooVuw

Original comment by ops...@gmail.com on 16 Nov 2013 at 2:35

[GoogleCodeExporter]

Sounds like something that xulrunner should provide in there .pc file. So that 
when pkg-config --cflags xulrunner is run (which configure does do). This value 
should come out. If you want to provide a patch I will merge it in otherwise.

Original comment by kdeko...@gmail.com on 16 Nov 2013 at 1:54

[GoogleCodeExporter]

I put in a workaround for xulrunner 26, but I still thing this is something 
that xulrunner should provide in its pkg-config files.

Original comment by kdeko...@gmail.com on 3 Jan 2014 at 4:34