search

manio / vdr-plugin-dvbapi

VDR dvbapi plugin for use with OSCam
http://www.streamboard.tv/wbb2/thread.php?threadid=40060
GNU General Public License v2.0
58 stars 25 forks source link

Buffer overflow #112

Closed AndreyPavlenko closed 8 years ago

AndreyPavlenko commented 8 years ago

Hi,

There is a similar issue filed against VNSI - https://github.com/FernetMenta/vdr-plugin-vnsiserver/issues/55, however I can reproduce it with streamdev as well. Thus, I assume the issues is in DVBAPI and it was introduced by this commit - 837043e3d768ae46bf1cb39020b8c8865b6036f6. If I roll back this commit both vnsi and streamdev work fine.

Here is the log with streamdev - http://pastebin.com/UUCvh5SV .

manio commented 8 years ago

Can you provide similar logs for the case when it is working ok after the same channel starts? I cannot reproduce this problem here. The buffer overflow is probably because your VDR want to stop decrypt the channel.

Can you also try my fastecm branch? Is it better when you use it?

And I don't understand how this is related with FernetMenta/vdr-plugin-vnsiserver#55? Please explain.

AndreyPavlenko commented 8 years ago

I think that both errors are caused by the same issue which results to buffer overflow. If I revert the commit mentioned above both errors disappear.

I'll provide you the logs a bit later today.

AndreyPavlenko commented 8 years ago

Here is the log reproduced with c97e154 - http://pastebin.com/ZKpfeXkU . Tried with the fastecm branch - the same issue - buffer overflow.

FernetMenta commented 8 years ago

the commit in question is also the cause for https://github.com/FernetMenta/vdr-plugin-vnsiserver/issues/57#issuecomment-229324513

The channel starts to stream and out of a sudden the stream is scrambled again. A revert of this commit cures the issue.

manio commented 8 years ago

Ok, it seems that it has to be done properly, for now I am reverting this commit. Thanks guys!