search

manish-yadav / pdns-gui

Automatically exported from code.google.com/p/pdns-gui
0 stars 0 forks source link

domain edit check #21

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 

File
apps/frontend/modules/domain/actions/actions.class.php
line 275
there is this test: if 
(!preg_match('/^[a-z]{1}[a-z0-9\.\-]+[a-z0-9]{1}$/',$data['name']) || 
strlen($data['name']) > 63)

I think there should be test based on (RFCs 952 and 1123)
for example:
if 
(!preg_match('/^([a-zA-Z0-9]([a-zA-Z0-9\-]{0,61}[a-zA-Z0-9])?\.)+[a-zA-Z]{2,6}$/
',$data['name']) || strlen($data['name']) > 253)

Original issue reported on code.google.com by cleo.l...@gmail.com on 30 Dec 2010 at 11:15

GoogleCodeExporter commented 8 years ago 
Do not forget that we may have that kind of record : 
*.mydomain.com

I have grouped many issues resolved here in a pdns-gui fork on github: 
https://github.com/odoucet/pdns-gui

Original comment by webmas...@ajeux.com on 2 Nov 2012 at 11:24

GoogleCodeExporter commented 8 years ago 
I also can't add records with asterix.
*.mydomain.com   IN A 1.2.3.4

Original comment by Dicr.Tarasov on 24 Nov 2012 at 3:13