search

manishsaraan / email-validator

email syntax validator npm module. fast and pretty robust
The Unlicense
434 stars 79 forks source link

New npm version release for latest code on github #79

Open anupamSharma94 opened 1 year ago

anupamSharma94 commented 1 year ago

Hi @manishsaraan,

We are using your npm module - email-validator for basic email validations in our NodeJs based application (https://www.npmjs.com/package/email-validator).

We observed that the module was last published 5 years ago with the version 2.0.4. However there are no tags or releases present in the git repo.

npm version 2.0.4 points to the Git commit - https://github.com/manishsaraan/email-validator/blob/2c16df5e6f79b34ccae1baeb62efaee218eb73ac/index.js

We are getting the following issue in the 2.0.4 version release - the email domain length check allows only 254 characters. But as per some global standards for email, the domain length can be of 255 characters.

We checked the git repository and found that some fixes have been made (for the domain length check) after the last npm publish.

PR where the issue was fixed - https://github.com/manishsaraan/email-validator/pull/53

Our application works fine with the latest master branch commit (https://github.com/manishsaraan/email-validator/commit/df02ecd8f0c53041c53fac986e842df0ec935ebe).

Can you please review and advise if a new npm version can be released, so that our application can fetch the latest code from npm.

Thanks, Anupam

houd1ni commented 1 year ago

@manishsaraan would be excellent if I could manage this.

malikzype commented 9 months ago

Can we merge the PR and rollout a new update?

sefinek24 commented 8 months ago

Some time ago, I decided to create my own module responsible for validating email addresses. It might be useful for someone (: It also supports browsers.

Demo: https://cdn.sefinek.net/npm/email-validator/test/browser Npm: https://www.npmjs.com/package/@sefinek/email-validator