maniyaom / Movie-Ticket-Booking

https://movie-ticket-booking-five.vercel.app
MIT License
38 stars 109 forks source link

[Feat]: Form Validation and Adding a default time for Listing movies #228

Closed Akshithsaai closed 1 month ago

Akshithsaai commented 1 month ago

Feature Description

Form Validation and Default Time for Movie Shows

Provide a detailed description of the feature

Issues:

While Listing movie a Movie on Ticketify, The Form is not validated for most of the fields. example : Movie Language should not be a number, Ticket Price should not be a string. I have created a test movie with the ticket price as a string it shows insufficient Balance even though there is some balance in my account.

Also I propose to add a default movie Time Feature.

Solution

  1. To implement form validation in listing the movies.
  2. Changes to Movie Timings as shown below.

Please check screenshots.

Put here any screenshots or videos (optional)

Current version:

image image image

image

Proposed Version

Validated Form and image

By submitting this issue, you agree to

Other Information

github-actions[bot] commented 1 month ago

@Akshithsaai

Thank you for raising this issue! 🎉🙌

We truly appreciate your contribution to this project and will review the details shortly. 🛠️✨ We will get back to you soon!

Thank you for your patience! 🙏

maniyaom commented 1 month ago

@Akshithsaai The "insufficient balance" message appears because the total cost of the ticket exceeds your current account balance. Please create another account, and that should resolve the issue.

Akshithsaai commented 1 month ago

@Akshithsaai The "insufficient balance" message appears because the total cost of the ticket exceeds your current account balance. Please create another account, and that should resolve the issue.

@maniyaom As I have created a string value for movie ticket price. I believe entire ASCII value is taken as the price. I have checked my balance , it was showing 5000 INR.

maniyaom commented 1 month ago

Have you added any unit for price like "300 Rs." ?

You just have to add the value in number only.

Akshithsaai commented 1 month ago

Yeah @maniyaom , currently the input is allowing to enter string values also . This is a major bug to be fixed for the functionality of the booking . So I am working on this form validation. I will be able to complete by today night.

Akshithsaai commented 1 month ago

@maniyaom I have Created a pull request on the issue. Its totally resolved. Please check it to merge.

github-actions[bot] commented 1 month ago

@Akshithsaai

🚀 The pull request associated with this issue has been successfully merged! This issue will now be closed as it has been resolved.

🎉 Thank you for your efforts! If you have any more ideas or find other issues on our website, feel free to contribute further! 🙏