Automatic time shall be applicable

manjaro / manjaro-settings-manager

This repo has been archived. Our code is now hosted at

https://gitlab.manjaro.org/

GNU General Public License v3.0

18 stars 19 forks source link

Automatic time shall be applicable #111

Closed es20490446e closed 6 years ago

es20490446e commented 6 years ago

HOW TO REPRODUCE:

Go to "Manjaro Settings Manager -> Time and Date".
Mark the option "set time and date automatically".

RESULT:

The "apply" button stays greyed out, where it should be activated.
Even better if the option was enabled without needing to press any "apply" button at all.

jhrdina commented 6 years ago

I tried the obvious solution to add

this -> setApplyEnabled( this, true );

below line https://github.com/manjaro/manjaro-settings-manager/blob/a0272302536cb028a892f68d610256c4b83ed0eb/src/modules/timedate/TimeDatePage.cpp#L54

Unfortunately it seems like one extra toggled event is fired on msm startup, as this fix causes the following awkward behavior:

Go to "Manjaro Settings Manager -> Time and Date", the "apply" button is enabled (it shouldn't)
Go back to main screen
Open "Time and Date" again, the "apply" button is disabled (as it should be)

vfjpl commented 6 years ago

Please test manjaro-settings-manager from unstable.

es20490446e commented 6 years ago

Okay. Added to my todo list.

jhrdina commented 6 years ago

I've tested the non-kde version used in XFCE and everything seems to be working in 0.5.4-7 from unstable: Apply button gets enabled properly and time/date textfields are also enabled/disabled as they should.

es20490446e commented 6 years ago

Works in KDE too.