manjaro / pacman-mirrors

This repo has been archived. Our code is now hosted at
https://gitlab.manjaro.org
GNU General Public License v3.0
25 stars 16 forks source link

Somethings wrong now #87

Closed fhdk closed 7 years ago

fhdk commented 7 years ago

-i --default loads no mirrors

@Huluti it was working yesterday and if I revert the changes from last night it works as expected

There is a shell-script and a checklist for outputs in tests folder. I have reverted some of your changes since I couldn't find the culprit.

fhdk commented 7 years ago

whatever was wrong is fixed now commit https://github.com/manjaro/pacman-mirrors/commit/ea5033e79ac865d1dc46b816c2a2bf60bf7b6095

Huluti commented 7 years ago

So you have revert all? I think that there was good changes. What do you think?

fhdk commented 7 years ago

I am sorry - There were some really good simplifications of expression all-right but I first tried reverting one by one but I couldn't find the culprit so I had to revert everything - but I will go through the commits and add your changes - OK?

Huluti commented 7 years ago

No problem at all. I understand :). Just add them one by one when you'll have some time.

fhdk commented 7 years ago

Do you have an idea to how I test the shell return value from api.

It returns -n where n er 1,2,3 depending on branch in config

I use sys.exit(-1) for stable

How do I check this value from a shell script?

Huluti commented 7 years ago

I have no idea... sorry.

fhdk commented 7 years ago

sys.exit(self.config["branch"])

#!/usr/bin/env bash

BRANCH=$( (pacman-mirrors --api --get-branch >&1) 2>&1 )
echo ${BRANCH}
fhdk commented 7 years ago

@Huluti Your good changes is back and I found not why but where the code failed. That one I have not used :smile_cat:

fhdk commented 7 years ago

@Huluti Can you build an upload a new pacman-mirrors-dev package?

Huluti commented 7 years ago

I don't have this power yet. ☹ Hope @philmmanjaro will do.