manjaro / pacman-mirrors

This repo has been archived. Our code is now hosted at
https://gitlab.manjaro.org
GNU General Public License v3.0
25 stars 16 forks source link

Function error in dev-branch #99

Closed philmmanjaro closed 7 years ago

philmmanjaro commented 7 years ago

@fhdk: please recheck our dev-branch. Seems we have a regression:

(47/50) Aktualisiere pacman-mirrors-dev            [######################] 100%
Traceback (most recent call last):
  File "/usr/bin/pacman-mirrors", line 55, in <module>
    pm.run()
  File "/usr/lib/python3.6/site-packages/pacman_mirrors/pacman_mirrors.py", line 552, in run
    self.command_line_parse()
  File "/usr/lib/python3.6/site-packages/pacman_mirrors/pacman_mirrors.py", line 205, in command_line_parse
    if args.sync:
AttributeError: 'Namespace' object has no attribute 'sync'

Stable branches are fine.

philmmanjaro commented 7 years ago

Please also check v4.1 series, as some checks failed ...

fhdk commented 7 years ago

I removed the -y --sync arg - I realized it was confusing and also it is not a pacman clone but a mirrorlist helper and the -u --update should not have been there at all.

I must keep the purpose of pacman-mirrors as it is - mirrorlist generator - not a nurse :)

This regression is fixed with https://github.com/manjaro/pacman-mirrors/commit/8939ed64a26f9e1face25f2c83f4012c2547021a

fhdk commented 7 years ago

I have checked - I fixed another bug in 4.1-series.

Status For 4.1.3-stable

For 4.2.0-dev