Build chromium and mozilla app

manjaro / release-plan

Roadmap for our Manjaro install media releases

85 stars 7 forks source link

Build chromium and mozilla app #188

Closed Ste74 closed 6 years ago

Ste74 commented 6 years ago

Continuing from here and considering what happen now with manjaro-browser-settings ( no idea why pre hook not work in some situation ). If the idea of @jonathonf is the future i think we can build now ( maybe only ff for now) and not invest more time to solve the issue. Let me know what think because for me the only workaround now is rebuild our ff how we rebuild before the introduction of hook into m-b-s.

@philmmanjaro @oberon2007 @Kirek @jonathonf ?

philmmanjaro commented 6 years ago

Maybe you create two hooks for each package. Having a joined hook might create the issue. However, I think the issue is in our repackaging. Since the ini is not known to pacman to be part of firefox or firefox-developer-edition it always complains. As soon as you have it installed once, pacman-db knows and it works. So we have to fix the first installation.

philmmanjaro commented 6 years ago

We have to split the hooks. This is why:

currently the hook is creating the ini-files for both, firefox and firefox-developer-edition.
when you try to additionally install the developer edition, pacman claims to already have the file and fails.
we can only create the file after firefox or firefox-developer-edition got installed
since we never had the ini-file for firefox package, we have to use manjaro-settings to remove the file, if possible.

Ste74 commented 6 years ago

Ok, as comment in our forum let me try if over write instead of copy the ini file solve the issue.. When go home repack it and also yesterday read the pkgbuild of ff and not remember correctly but Seem the api keys are stored in a file.. If is correct we can over write these..

philmmanjaro commented 6 years ago

I think I already fixed it hours ago ...

Ste74 commented 6 years ago

I See your commit before ;)