Theme Toggler Hydration Warning Handled

manjaro / website

Official Manjaro Website

https://manjaro.org

Apache License 2.0

9 stars 9 forks source link

Closed walleeva2018 closed 1 month ago

walleeva2018 commented 3 months ago

In Navbar View Theme Switcher which should be a client-side component was rendering as a Server side component. Fixed that

romangg commented 3 months ago

Alternative is to use v-show instead of v-if. I think I would prefer that as more can be statically generated this way. What do you think?

walleeva2018 commented 3 months ago

Alternative is to use v-show instead of v-if. I think I would prefer that as more can be statically generated this way. What do you think?

Yeah As Its navbar the load time will be faster. I will update that

walleeva2018 commented 3 months ago

@romangg Let me know if there is any problem

romangg commented 3 months ago

With the v-show the change to ClientOnly is not needed anymore. So this change needs to be removed from the branch/PR.

romangg commented 3 months ago

The cleanest solution is to use interactive rebase for that: https://git-rebase.io/

walleeva2018 commented 3 months ago

With the v-show the change to ClientOnly is not needed anymore. So this change needs to be removed from the branch/PR.

Yeah My bad. Is it okay now?

romangg commented 2 months ago

Thanks for the update. The problem is that this revision still contains changes that are as far as I see not needed anymore.