search

manjaro / website

Official Manjaro Website
https://manjaro.org
Apache License 2.0
9 stars 9 forks source link

fix #34 #46

Open codesardine opened 2 months ago

romangg commented 2 months ago

Thanks. Can you give some more info? Why png instead of webp? Does it have better compatibility with shadows?

Add this info also to the commit message and use conventional commit format so the pipeline passes.

codesardine commented 2 months ago

Thanks. Can you give some more info? Why png instead of webp? Does it have better compatibility with shadows?

Add this info also to the commit message and use conventional commit format so the pipeline passes.

The image format that does matter too mutch as long as it is small the new image does not have a background so when we apply the drop-shadow the shadows only go on the image and not the square cube behind it, both webp or png have support for alpha channel.

romangg commented 1 month ago

The outline of the llama looks pixelated here in dark mode. But I think removing the squares looks better.

The drop shadow on the top image makes the graphic less appealing. Remove it from there please.

codesardine commented 1 month ago

The outline of the llama looks pixelated here in dark mode. But I think removing the squares looks better.

The drop shadow on the top image makes the graphic less appealing. Remove it from there please.

In what browser? here vivaldi and firefox show a good image. did you try and disable hardware acceleration, could be a issue on your local machine, you were also not able to visualize the box shadow on your end. Also you have to decide if you want shadow or not, it has to be consistent shadows on none of the images or shadows in all images. Screenshot from 2024-09-24 20-37-48

romangg commented 1 month ago

The issue might be due to my hidpi screen.