search

manjurulhoque / django-job-portal

Job portal application using Django
MIT License
567 stars 244 forks source link

Standardize all file with a pass of pre-commit #55

Open neodark opened 2 years ago

neodark commented 2 years ago

Update pre-commit-config file and run a pass of pre-commit over all files for a better code standardization.

Fixes #54

neodark commented 2 years ago

@manjurulhoque : if you don't mind could you also add this one with a hacktoberfest-accepted label please?

manjurulhoque commented 2 years ago

Huge changes. Need to check carefully.

neodark commented 2 years ago

The PR #53 is much smaller and fixes your issue with date and time.

This PR basically only has a better code formatting. But sure go through!

Very interesting project by the way. You have some other ones worth it too.

neodark commented 2 years ago

Another possible improvement:

I have noticed that your project only runs under python version 3.8 (I had to install your project in a conda environment that runs python 3.8). Don't forget that 3.8 is now considered outdated and there's only security support until mid-october 2014. But no more updates will be provided. You should think of switching your code base to python 3.9 or 3.10.

Of course this has nothing to do with this PR or my other one. Just a side note. (I should have added it to your issues list actually)