search

manki11 / ExerciserReact

React code of Exerciser Activity. GSoC 2018
Apache License 2.0
2 stars 54 forks source link

Issues in setting up repo locally #15

Open imdhruvgupta opened 5 years ago

imdhruvgupta commented 5 years ago

The project contains sugarizer dependencies which are being imported in Sugarizer.js file. webpage But since the lib directory is outside of the src folder it is not allowed to import from it. A symlink of lib directory in src would suffice.

imdhruvgupta commented 5 years ago

I have created a pull request - https://github.com/manki11/ExerciserReact/pull/16#issue-253702791 . Please review @llaske @manki11 .

manki11 commented 5 years ago

You haven't followed "setting up the development environment" in the readme. After doing an npm install you need to copy the lib folder into the node_modules.

imdhruvgupta commented 5 years ago

Hi @manki11 . Even after copying the lib folder in the node modules. I have to change the relative path of the imports in sugarizer.js file. Won't it be better to have a symlink and have rather simpler process of setup? What do you say?

siddhant1 commented 5 years ago

Will be solved by #18