search

mankindsoftware / angular-isotope

AngularJS directives to easily work with JQuery Isotope.
http://mankindsoftware.github.io/angular-isotope
204 stars 79 forks source link

$ not defined #42

Open designbyadrian opened 9 years ago

designbyadrian commented 9 years ago 
ReferenceError: $ is not defined
    at Object.store (script.js:33170)
    at new <anonymous> (script.js:32804)
    at Object.invoke (script.js:4203)
    at $get.extend.instance (script.js:8493)
    at script.js:7739
    at forEach (script.js:331)
    at nodeLinkFn (script.js:7738)
    at compositeLinkFn (script.js:7117)
    at publicLinkFn (script.js:6996)
    at $get.boundTranscludeFn (script.js:7135)

I suspect these lines:

storedOptions = $.extend.apply(null, [true, storedOptions].concat(option));
return $.extend(reduction, item);

which are likely assuming JQuery.

designbyadrian commented 9 years ago

Both could use

angular.extend

instead

MattiJarvinen commented 9 years ago

+1