mankoff / gdb_fortran_tools

Tools to help debug Fortran code with gdb - plotting, saving, and Numpy functions.
MIT License
2 stars 0 forks source link

Pretty-printer for dynamic types #2

Open ZedThree opened 1 month ago

ZedThree commented 1 month ago

Hi @mankoff, this looks like a really useful package! Awhile ago I wrote a gdb pretty-printer for Fortran dynamic types (class): https://github.com/ZedThree/Fortran-gdb-pp

If you're interested, I could add this to your package?

mankoff commented 1 month ago

Hi @ZedThree

I'm aware of your pretty-printer. I haven't used it yet, but assumed that I would install it when the need came up.

If you want to open a PR I think I'll accept it, but I'm a little wary. Let's discuss.

The is some benefit to multiple tools in fewer packages because then when someone installs one thing they get more features. But it increases complexity and maintenance issues. I'm also a fan of the unix approach of many small tools that each do one thing - contrary to the generic name I chose for this tool.

I'm also not proficient in GDB programming. This tool functions but only because I took https://github.com/X-Neon/gdbplotlib and commented out a bunch of stuff and made a few minor changes. There's lots of code for C still lying around, some commented out, some probably running that maybe does or does not need to be there. There's Python package (PyPI?) code (setup.py) that I've never run, etc. The tool works for me. I find it incredibly useful, which is why I shared it at https://fortran-lang.discourse.group/t/the-state-of-gdb-in-fortran/4726/4?u=mankoff which is I assume how you found it. All this is to say, I'm not sure you want your name associated with this code, and I'm unlikely to be able to address any non-trivial issues raised with your contribution. That may not matter - whatever issues arise can be left open as they are on your GH repo, and I'm also unlikely to be able to address non-trivial issue with my own contribution...

So, given all this, if you're OK with the quality, and want to contribute your pretty-printer here, I think that's fine.