mankyd / htmlmin

A configurable HTML Minifier with safety features
https://htmlmin.readthedocs.org/en/latest/
Other
130 stars 40 forks source link

missing git tags to corresponding pypi releases #49

Open anthraxx opened 5 years ago

anthraxx commented 5 years ago

Releases published on pypi should also have their corresponding commits tagged in git and published to github for transparency.

Please push missing tags (especially latest)

mgorny commented 1 year ago

So apparently @wilhelmer has taken over the PyPI, made a new release but there's no sdist, no git tag, no issue tracker on their fork and all the URLs are pointing back there. Sigh.

wilhelmer commented 1 year ago

I didn't take over anything 😄 I just created a fork to solve #66 for our own project. I published it as htmlmin2 for technical reasons, but it's not meant as an official successor to htmlmin.

That being said, I just added tags for the last 3 releases 😉

mgorny commented 1 year ago

Thank you.

Unfortunately, since your fork is installed as htmlmin (i.e. the same package as the original), it is impossible to install both htmlmin and htmlmin2 on the same system. This in turn means a packaging nightmare where mkdocs-minify-plugin requires htmlmin2 and e.g. flask-htmlmin requires htmlmin. Since they both cannot be installed simultaneously, this now means that mkdocs-minify-plugin cannot be installed simultaneously with any other package using htmlmin.

On top of that, every distribution will probably need to patch htmlmin anyway to resolve the bug in question.

wilhelmer commented 1 year ago

Oops, didn't know that, thanks for the explanation! So I should rename everything in the fork from htmlmin to htmlmin2 and then use import htmlmin2 in our project?

mgorny commented 1 year ago

That's one possibility. Unfortunately, it's not a very good option because we'll effectively have two almost identical htmlmin and htmlmin2 packages, at least unless you decide to actively maintain htmlmin2 and other projects switch to it.

That said, it may be worthwhile to ask maintainers of flask-htmlmin (@hamidfzm) and pelican-minify (@rdegges) if they're interested in co-maintaining a fork.

mankyd commented 1 year ago

Chiming in here in the middle of the workday: I have been negligent in my duties to this project.

I am willing to discuss sharing or handing-over ownership of this project.

I wrote this years ago when I worked on Google's Pagespeed and "fast webpages" was at the forefront of my mind.

I haven't worked on that project - or anything web related even - in almost 8 years. Between work and life responsibilities, this project doesn't get the attention it deserves from me. Couple that with the fact that I am not entirely "proud" of this code anymore, and my motivation to commit time to it is delinquient.

If you're interested, let's find a way to make that work.

wilhelmer commented 1 year ago

Ah wonderful, hi Dave! 👋

I see two solutions here:

1) Cherry-pick this commit and release a new version on PyPI, since this is the only change our project is asking for 2) Give someone else rights to maintain the project, both on GitHub + PyPI.

mgorny commented 1 year ago

@mankyd, ping.

DonDeWitt commented 1 year ago

@mankyd ping

raratiru commented 4 months ago

@mankyd Yo! Give me a fat beat!

https://youtu.be/YGpR4ceGxW0?feature=shared

Remi-Gau commented 2 months ago

@mankyd I'd be ok taking over maintenance of this repo