search

manna-harbour / qmk_firmware

See the "forkreadme" branch or the following link for a description of branches maintained in this fork.
https://github.com/manna-harbour/qmk_firmware/blob/forkreadme/readme.org
GNU General Public License v2.0
281 stars 64 forks source link

Add a split_3x6_4 layout #16

Closed bromanko closed 3 years ago

bromanko commented 3 years ago

This layout is used by keyboards like the torn.

manna-harbour commented 3 years ago

It looks like there is no official split_3x6_4 community layout in QMK yet. New boards now have a descriptive layout macro name rather than just LAYOUT, but actually supporting the community layouts feature requires a few extra steps. You could submit a PR to QMK for that if you're interested (but I don't know of any other candidate boards). See the QMK PRs for split_3x5_3 and split_3x6_3 for reference.

For miryoku on torn and this PR, it would be sufficient to just change this new directory to be under torn/keymaps instead.

Thanks!

bromanko commented 3 years ago

Got it! Do you want me to move it to the Keyboards section of the .org file as well?

manna-harbour commented 3 years ago

Yes, Torn under Keyboards. Thanks!

manna-harbour commented 3 years ago

I see you've added split_3x6_4 to QMK (https://github.com/qmk/qmk_firmware/pull/11684), so I can add this now as-is. Thanks!

bromanko commented 3 years ago

Thanks for the tips on the QMK PR. I’ll add that so you can merge this as is.

manna-harbour commented 3 years ago

It should work as-is, so I can merge it now. The other things are just niceties I think. But QMK might decide to revert if they didn't notice it was a new layout (they might have confused it with 3x6_3). I might just merge the keyboards version now, and if the QMK PR sticks I can change it later to the layout version (it won't make any practical difference until there is another board using that layout anyway).

manna-harbour commented 3 years ago

Added as keyboard for now. Will change to layout if the layout is used by another keyboard. You'll need to merge with QMK master to use. Thanks!