Closed sunaku closed 1 year ago
I've replaced the BILATERAL_COMBINATIONS_FLASHMODS
mask with a BILATERAL_COMBINATIONS_DEFERMODS
timeout for PR #48:
-#define BILATERAL_COMBINATIONS_FLASHMODS MOD_MASK_GUI
+#define BILATERAL_COMBINATIONS_DEFERMODS 100
For your testing convenience, I've created a modernized version of this PR that is updated to a recent QMK mainline (0.18.6).
Superseded by PR #56.
Thanks to the increased typing speed made possible by PR #48, I discovered a blind spot in the bilateral combinations concept and patched it in a new optional feature called "crossover" bilateral combinations (implemented in this PR) to catch fast "rolls" that cross the left/right keyboard boundary. For example, imagine that you had Miryoku-style home row mods on the standard QWERTY layout so that typing the word "jam" involves the
RSFT_T(KC_J)
andLGUI_T(KC_A)
keys. :point_right: Regular bilateral combinations would ignore this combination since the keys are located on different sides of the keyboard, thereby sendingRSFT(KC_A)
to the computer. :point_up: In contrast, crossover bilateral combinations catch this combination (if you're quick enough, according to a configurable timeout) and sendKC_J
andKC_A
to the computer, thus avoiding accidental mods.Here is the relevant portion of my
config.h
file which activates both patches to provide the best typing experience I've felt since switching to Miryoku's home row mods ~2 years ago, as detailed in Taming home row mods with Bilateral Combinations:You also need to add the following line to your
rules.mk
file to enable QMK's deferred execution facility, used by DeferMods:Note: QMK's deferred execution feature was introduced 1 year later (on 16 November 2021 in commit 36d123e9c5a9ce0e29b9bc22ef87661bf479e299) after the latest in Miryoku's bilateral-combinations branch! So in order to try out my latest changes, you'll need to update this branch to a more recent version of mainline QMK. I've already done this (resolving merge conflicts) in a separate branch based on 0.18.6, so simply check out that branch and configure your
config.h
andrules.mk
files (as I've documented previously) to try it out.