search

mannau / h5

Interface to the HDF5 Library
Other
70 stars 22 forks source link

Add support for inspecting of HDF5's compound & time datatypes. #29

Closed atheriel closed 8 years ago

atheriel commented 8 years ago

Note that this does NOT add reading or writing support. The idea is to make it possible to view compound/time datasts in h5 even though it cannot currently read them. This PR will allow the creation of DataSet objects for datasets with these types, but they cannot be read into R itself.

This commit contains a change to the API in src/Helpers.h -- alloc and read functions now need full H5::DataType information. This is not strictly necessary for this feature, but it probably will be when full support for e.g. compound datatypes is added.

Happy to make changes to this PR as requested!

mannau commented 8 years ago

Looks good! Thanks for the addition! I'll add some test cases for compound and datetime in a later. Best, m