manniru / android-xbmcremote

Automatically exported from code.google.com/p/android-xbmcremote
0 stars 0 forks source link

Long press to reorder songs in music playlist #357

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Have multiple songs in playlist
2. Want to change the order
3. Can't. :)

What is the expected output? What do you see instead?
It would be nice if "long press" (or whatever the right android term is), as 
compared to tap to play the song, in the playlist would select and let you drag 
the song to reorder songs. Right now "long press" does nothing - it visually 
flashes as if you're selecting the song, but you can't move the song up or down 
the playlist.

What version of XBMC Remote are you using?
0.8.3-beta1

Which Android device are you using (and which ROM, if custom)?
Motorola Droid, 2.1

Which XBMC revision are you running and on which platform?
9.11 CVS

Please provide any additional information below.

Original issue reported on code.google.com by davef....@gmail.com on 12 Aug 2010 at 3:44

GoogleCodeExporter commented 9 years ago
As far as I can see the HTTP API of XBMC doesn't support sorting of the 
playlist. Maybe through JSON RPC... will have to do some more researching.

Original comment by till.ess...@googlemail.com on 24 Aug 2010 at 8:52

GoogleCodeExporter commented 9 years ago
Yeah this isn't obvious at all. I'll nevertheless accept it, but it won't be 
done soon.

Original comment by phree...@gmail.com on 3 Sep 2010 at 1:03

GoogleCodeExporter commented 9 years ago
...long press or another way to change the songs order would be great. very 
good work, thank you very much

Original comment by sergioll...@gmail.com on 23 Nov 2010 at 8:37

GoogleCodeExporter commented 9 years ago
I started working on this yesterday, and it's quite a bit more challenging than 
I thought it would be. I have something that works, but I'm not sure if the UI 
is ideal. I'd love to get some feedback.

Below is a short video showing what I've done so far. In the video, I 
long-press an item in the playlist to get to the "Edit Playlist" screen. From 
here, I scroll up/down, delete a few items, rearrange some, and save it.

(the video was captured at a really low framerate and then sped up, so it's 
choppy in places)

http://www.youtube.com/watch?v=r6LhS-M4U1o

Some of my concerns:

* The only way to get to the "Edit Playlist" screen is to long-press an item. 
This seems non-intuitive, since it's not something that's done on a per-item 
basis. Should there be alternate ways to get to this screen (another button 
along the bottom, a menu option, etc)?

* Each item has a checkbox (for deleting) and a grabber (for rearranging). If 
you mark some items for deletion, a "delete items" button pops up and the 
save/cancel buttons disappear. This seems to flow well, but I'm probably 
biased. Is the process too confusing? Is there a better way to handle deleting 
and rearranging?

* I put the checkbox and grabber on the left side so they wouldn't conflict 
with the scroll bar. Does it look alright, or should I change the layout?

* It takes a little while to save, but I don't see any easy optimizations. I'm 
not using WiFi, though, and I suppose it's better to have a slow feature than a 
missing one.

Original comment by Anthony....@gmail.com on 27 Nov 2010 at 6:46

GoogleCodeExporter commented 9 years ago
GREAT WORK!!
my feedback:
1. maybe the option "Edit playlist" would be appear when press the "menu" 
button, or when you press this button, 2 options: "delete items" appear 
checkbox (for deleting) or "move items" and apear in the list a grabber (for 
rearranging).

2. another way would be in the actual playlist,using the icons on the left, 
without a special menu. long-press in this icon for rearranging and short-press 
for selection to delete. 

3. the checkbox and grabber are ok in the left side.

4.is posible to see the artist name in the playlist?

When we can see this change in the program?

I hope to be helpful. THANKS!!!

Original comment by sergioll...@gmail.com on 28 Nov 2010 at 11:28

GoogleCodeExporter commented 9 years ago
Is this already in your branch? Looking great BTW!

Original comment by phree...@gmail.com on 28 Nov 2010 at 5:08

GoogleCodeExporter commented 9 years ago
The way to reorder songs on an Android play list is to re-add every song on the 
list starting with the song you want last and ending with the song you want 
first.  Then delete all the duplicates after the last song. Slow and stupid, eh 
what? Cheers!

Original comment by sir.rh...@gmail.com on 1 Dec 2010 at 8:00

GoogleCodeExporter commented 9 years ago
sergiollanosm:

I agree with adding "Edit Playlist" as an option in the menu, but I'll need to 
find a good icon for it that's consistent with the rest of the app. I'm 
terrible at graphics.

For adding the artist's name to the playlist, check out issue 428.

phreezie:

It's not in my branch yet. To make the sample, I copy/pasted code from an 
Android project that's under the Apache 2.0 license. This seems to be 
incompatible with GPLv2. It wasn't much code (or anything complex), so I'll 
just reimplement it.

I also want to make some quick little optimizations. All of the playlist 
editing is done in memory. When you save it, the entire XBMC playlist is 
cleared and all of the items are re-added (in the correct order). This makes it 
easy, but there are several cases where this is way too much work.

Once I get some time to fix these (maybe tomorrow evening), I'll commit the 
changes.

Original comment by Anthony....@gmail.com on 3 Dec 2010 at 12:57

GoogleCodeExporter commented 9 years ago
Sounds great!

Original comment by phree...@gmail.com on 3 Dec 2010 at 7:47

GoogleCodeExporter commented 9 years ago
Well, one day turned into a month and a half, but I finally made an initial 
commit of this fix into my branch.

I added a menu entry on the music playlist screen that links to the edit 
playlist screen, but I just picked some icon. That could probably be changed to 
something more appropriate.

I'm sure it's full of bugs and missing features, and I don't really play music 
on XBMC enough to catch them. Hopefully this is a start, though.

Original comment by Anthony....@gmail.com on 22 Jan 2011 at 5:24

GoogleCodeExporter commented 9 years ago
How to test this feature?
El ene 22, 2011 6:25 a.m., <android-xbmcremote@googlecode.com> escribi�:

initial

Original comment by sergioll...@gmail.com on 22 Jan 2011 at 1:52

GoogleCodeExporter commented 9 years ago
When can we expect this feature to be implemented in the official version? From 
what i see here the code for it was written 1.5 years ago and it has a 
milestone for Release 2.0. The current release is 0.8.8, so it sounds like it 
will take at least a couple of years before we can expect it?
It would be a shame because it's the one featuer i miss most! Is there any way 
i can manually add this feature myself? Or download a branched version that's 
not too much out-of-date that has this feature?
Also, why wait until 2.0 since the app itself is still in beta? Why not simple 
add it now?

Original comment by marty.ko...@gmail.com on 14 Jun 2012 at 12:54

GoogleCodeExporter commented 9 years ago
Kommer
du til å bli

Original comment by wwwomar...@gmail.com on 26 May 2014 at 12:54