search

mannkendall / Matlab

Matlab implementation of the code.
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Hardcoded seasons in MK_tempAggr() ? #4

Closed fpavogt closed 4 years ago

fpavogt commented 4 years ago

While porting the code over to Python, I noticed the following line 233 in MK_tempAggr.m:

            %compute xi-carre to test the homogeneity between months.
            Xhomo=nansum(Z(1:m).^2)-12*(nanmean(Z(1:m))).^2;

Shouldn't the 12 be replaced by n, since users can submit any number of seasons they want ?

The same question applies also to l. 257 of the same file.

mcollaudcoen commented 4 years ago

done