search

mannprerak2 / event_hub_flutter

EventHub View events at DTU... https://mannprerak2.github.io/event_hub_flutter
https://mannprerak2.github.io/event_hub_flutter
MIT License
8 stars 15 forks source link

Fix Icons for web(favicon) and android(launcher icon) #6

Closed mannprerak2 closed 4 years ago

mannprerak2 commented 4 years ago

Currently, the default Flutter icon is shown as favicon(web) or launcher icon(android). Replace them with the actual icons. The icons to be used can be found in assets directory.

Sirsho29 commented 4 years ago

Hi, I want to solve this issue.

mannprerak2 commented 4 years ago

Sure, go ahead @Sirsho29 (I presume after 1st October)

Sirsho29 commented 4 years ago

Hacktoberfest has already started. So I think I can solve now

Sirsho29 commented 4 years ago

I have created a PR. Please check and accept it. I have completed the web icon part.

mannprerak2 commented 4 years ago

Please complete the android icon part as well in the same PR.

Btw, hacktoberfest begins on 1st October, any PR's made before will probably not be counted. (I am not sure)

Sirsho29 commented 4 years ago

I just completed the android part.

I got a mail from digital ocean about start of the hacktoberfest and in their website also its showing that it has started. Even I knew that it starts from 1st october.

mannprerak2 commented 4 years ago

Closed by #8