mannprerak2 / event_hub_flutter

EventHub View events at DTU... https://mannprerak2.github.io/event_hub_flutter
https://mannprerak2.github.io/event_hub_flutter
MIT License
8 stars 15 forks source link

Placeholder image added #9

Closed AlKun25 closed 4 years ago

AlKun25 commented 4 years ago

Resolved Issue #4 I have added a placeholder image, but I would advise to use loading spinner as a placeholder. And keep an image for failed to download error. Here are its results and how it appears:

EventList EventPage SocietyList SocietyPage
mannprerak2 commented 4 years ago

Hi @AlKun25 Great work. But I'd request you to use a more subtle image, a big cross catches a lot of attention, which we probably wouldn't want.You can search for error placeholder images and choose something you think is subtle and does not take the user's attention, perhaps something like this https://images.app.goo.gl/tfQGbM1ZERQx5AWEA

Also for your suggestion to use a loader, using a loader for this is not encourage according to material design guidelines and it makes sense, you dont want to see tons of loaders each for one image

And lastly, if you are doing this as part of hacktoberfest, I should remind you only the PRs made during 1st to 31sr October will be counted. (Although the registration has started) In that case you should close this PR and create a new one after 1st October

AlKun25 commented 4 years ago

Oh, that's right too about loading spinner. Also I did find images that were more subtle, but I wasn't sure whether they were copyright-free or not. Sorry about that. I will make another PR after 1st Oct with the right image. Will the one you mentioned work?

mannprerak2 commented 4 years ago

Will the one you mentioned work?

Not sure, but be sure to use a copyright-free image only, there are many websites for this, don't use Google image search.

AlKun25 commented 4 years ago

I did find an icon within flutter which is exactly like the image that you shared. Is it ok?

mannprerak2 commented 4 years ago

Not sure, we'll see when you make the PR.

AlKun25 commented 4 years ago

Is this fine?

image

mannprerak2 commented 4 years ago

Yes