mannprerak2 / nearby_connections

Flutter plugin (android) for sharing bytes and files Offline, (Based on the android Nearby Connections API)
https://pub.dev/packages/nearby_connections
BSD 2-Clause "Simplified" License
93 stars 30 forks source link

compileSdkVersion is set to 28 - Causing Build error #40

Closed SherwinJames closed 1 year ago

SherwinJames commented 2 years ago

Your compile version in your build.gradle for Android is set to "compileSdkVersion 28", causing compile errors:


C:\dev\flutter\.pub-cache\hosted\pub.dartlang.org\nearby_connections-3.1.0\android\src\main\java\com\pkmnapps\nearby_connections\NearbyConnectionsPlugin.java:448: error: cannot find symbol
                if (VERSION.SDK_INT < VERSION_CODES.Q
```)

Can you fix?
mannprerak2 commented 2 years ago

Hi, could you try running the example app, if it works, there's probably some misconfiguration. You can compare your pubspec.yaml file with the one is example.

mannprerak2 commented 2 years ago

If you really think this might be because of compile sdk 28, would you consider creating a PR for that?

SherwinJames commented 2 years ago

If you really think this might be because of compile sdk 28, would you consider creating a PR for that?

Flooded with work at the moment, not sure when I'll be able to get to that. For now I just changed the local cached copy of your plugin build.gradle file from compileSdkVersion 28 to 30, and that solves the compile issue (temporarily). By the way my applications pubspec.yaml matches you example pubspec.yaml (with regard to the sdk version: nearby_connections: ^3.1.0 )

mannprerak2 commented 2 years ago

Cool, I'll try to update this ASAP.

mannprerak2 commented 1 year ago

Closing this since it has already been completed.