search

manny405 / sapai

Super auto pets engine built with reinforment learning training in mind
MIT License
67 stars 21 forks source link

20220201 issues #17

Closed manny405 closed 2 years ago

manny405 commented 2 years ago

@alexdriedger Would you mind to make a review of the changes here that issues #12 #13 #14 have been addressed?

alexdriedger commented 2 years ago

It looks like those issues are resolved 👍 ~I'm seeing a new exception from Tiger func that involves FoodMultiplier, but that can be a new issue. (this issue is caused by cat and I'll submit a new issue)~

Can you add the following unit test to test_battles.py? This was failing before this change and is passing now

    def test_tiger_func_not_enough_values_to_unpack_exception(self):
        team1 = Team([Pet("fish")])
        team2 = Team([Pet("whale"), Pet("hedgehog"), Pet("fish"), Pet("rabbit")])

        test_battle = Battle(team1, team2)
        test_battle.battle()
manny405 commented 2 years ago

New test added as test_whale_without_swallow_target