search

mannynotfound / react-tweet

React.js component for rendering tweets as they are presented on Twitter.com
67 stars 43 forks source link

Add linkProps #14

Closed caiolopes closed 7 years ago

caiolopes commented 7 years ago

It also fix README id to id_str example

mannynotfound commented 7 years ago

Hmm. I think this prop is a little unclear. Nothing really lets you know that this is going to make the action link in the footer open as a new tab unless you follow the code.

Possible idea: add a linkProps that can take an object and assign it to all the links so you could do

linkProps={{target: '_blank', rel: 'noreferrer'}}

and have that propagate through to all links inside react-tweet

caiolopes commented 7 years ago

@mannynotfound oh, I realize that, so I change to your suggestion, and it really looks better because now it changes all links in the Tweet component to the desired behaviour.

mannynotfound commented 7 years ago

this LGTM! We should add a bit about this in the README. Thanks

mannynotfound commented 7 years ago

@caiolopes updated README and bumped these changes in 1.2.0