mannynotfound / react-tweet

React.js component for rendering tweets as they are presented on Twitter.com
67 stars 43 forks source link

Forking and changing the footer #16

Closed pan100 closed 6 years ago

pan100 commented 6 years ago

I assume there is no problem in making a fork of this and adding a new icon to the footer? I am making a Twitter app where I need a new icon in the footer.

Could you please explain what the 4th div in the Footer.js render is doing? Is it a placeholder? Can I just add something here or does it do something in rare cases? In the example app it is empty.

This one:

`

      </div> `
mannynotfound commented 6 years ago

What icon do you want to add to the footer? If its custom to your app I would say make a fork, but if its inline with latest twitter I would be open to a pull request.

That div is indeed a placeholder, its the icon that houses the "dm" button but since I knew I wasnt going to support DMing in this component, I left it out. The whole footer is static really.