Styled components - Githubissues

mannynotfound / react-tweet

React.js component for rendering tweets as they are presented on Twitter.com

67 stars 43 forks source link

Styled components #34

Open sudarshang opened 6 years ago

sudarshang commented 6 years ago

This PR is to get feedback on the right way to migrate this project to styled-components. I have only migrated the Video component for now. @art1fa please let me know if this is how #25 should be handled.

zebra-ok commented 6 years ago

Yeah looks fine :) Just two comments:

It probably makes sense to organize the styles in another place than the actual component. This is one example, but of course there's more than one way...
Move the dependency in devDependencies and peerDependencies (see this)

mannynotfound commented 6 years ago

hey guys, thanks for the PR! Was out of town all weekend so havent gotten a chance to look at this but will provide some feedback soon.