search

mannynotfound / react-tweet

React.js component for rendering tweets as they are presented on Twitter.com
67 stars 43 forks source link

Convert string 0 to 0px for react 0.15. #5

Closed chmac closed 8 years ago

chmac commented 8 years ago

We're using this with react 0.15 and seeing a ton of warnings in the console about CSS properties like margin getting the value '0'. I've converted all the instances of '0' to '0px'. I'm not actually sure if that's the appropriate solution or not, but it seems to have suppressed all the warnings on my setup. Merge at your own risk. :-)

mannynotfound commented 8 years ago

hey this looks good I'll take a look and merge + publish new version in a bit when I'm home

mannynotfound commented 8 years ago

@chmac Merged, made React/React-DOM peer dependencies, and changed all the 0px to just 0 integers because I think thats cleaner, and published to NPM. New version should be 1.0.15. Thanks!

chmac commented 8 years ago

Awesome, I think you're right about the 0 integer, I didn't realise that was an option, definitely cleaner. I was also working on a PR for 'peerDependencies' but wasn't sure how to test it, thanks for also taking care of that.