search

mannyzhou5 / evolutionchamber

Automatically exported from code.google.com/p/evolutionchamber
0 stars 0 forks source link

Method com.fray.evo.util.EcCacheMap.putAll(Map) makes inefficient use of keySet iterator instead of entrySet iterator #212

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Bug: Method com.fray.evo.util.EcCacheMap.putAll(Map) makes inefficient use of 
keySet iterator instead of entrySet iterator
Pattern id: WMI_WRONG_MAP_ITERATOR, type: WMI, category: PERFORMANCE

This method accesses the value of a Map entry, using a key that was retrieved 
from a keySet iterator. It is more efficient to use an iterator on the entrySet 
of the map, to avoid the Map.get(key) lookup.

--
I used FindBugs (findbugs.sourceforge.net) on the project source. Will go 
slowly through the 56 reported issues.

I will register each report I took action on in order to have a reference point 
in the future and for easier change log generation.

Original issue reported on code.google.com by netpr...@gmail.com on 20 Jul 2011 at 7:24

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r292.

Original comment by netpr...@gmail.com on 20 Jul 2011 at 7:26