Review 7: GraphExamples.jsx and ImageCarousel.jsx - Githubissues

manoa-inspire / MATP

MIT License

0 stars 0 forks source link

Review 7: GraphExamples.jsx and ImageCarousel.jsx #115

Open blakewatanabe opened 11 hours ago

blakewatanabe commented 11 hours ago

Overview

The focus for this code review will be centered around GraphExamples.jsx and ImageCarousel.jsx.

Please pay attention too:

Javascript issues
React components

Review Branch

Files to review

Checklists

Due date

10/28/24

For more information

The review process is documented at: http://courses.ics.hawaii.edu/ics414s21/morea/review/reading-idpm-review.html

cash-baker commented 10 hours ago

GraphExamples.jsx

(DE-01) Function blocks for displaying charts are reused, would consider refactoring to reduce code duplication
(DE-06) Code is clear and easy to read

ImageCarousel.jsx

(ES-01) No warnings or errors, avoid using eslint-disable https://github.com/manoa-inspire/MATP/blob/d09b01b4358045924bae5f8850640c2d13bf7ac7/app/imports/ui/components/ImageCarousel.jsx#L11
(DE-03) Eliminate any dead or commented-out code, or consider moving it to separate directory https://github.com/manoa-inspire/MATP/blob/d09b01b4358045924bae5f8850640c2d13bf7ac7/app/imports/ui/components/ImageCarousel.jsx#L129-L140