search

manodeep / Corrfunc

⚡️⚡️⚡️Blazing fast correlation functions on the CPU.
https://corrfunc.readthedocs.io
MIT License
165 stars 50 forks source link

Treat compiler warnings as errors on travis #120

Closed manodeep closed 7 years ago

manodeep commented 7 years ago

There is a reasonably broad mix of compilers and os' being tested on travis. The general development philosophy of Corrfunc is that compiler warnings are signs of code-smell and really should be treated as errors. While enforcing that repo-wide is impractical, simply because of the vast combinations of compilers and os, we can keep a check on code quality of running travis tests with the additional flag of -Werror.

manodeep commented 7 years ago

The fix will be in common.mk, check CI or TRAVIS env variables and if any one of them are set, add the -Werror flag to CFLAGS.