search

manodeep / Corrfunc

⚡️⚡️⚡️Blazing fast correlation functions on the CPU.
https://corrfunc.readthedocs.io
MIT License
165 stars 50 forks source link

Clarifying the install instructions #122

Closed tmcclintock closed 7 years ago

tmcclintock commented 7 years ago

In the "Preferred Install Method" section in the documentation you mention that you can add CC=yourcompiler if doing just the python installation. Having done the full line-by-line installation, it wasn't clear from the docs that you need to add CC=yourcompiler after all lines. This would be a minor fix that might save some confusion in the future :).

manodeep commented 7 years ago

How does that look?

tmcclintock commented 7 years ago

A lot better. It also turns out that you need to add the flag when you do make tests as well. Otherwise I'm satisfied. Thanks!

manodeep commented 7 years ago

Yup. All make commands associated with building/compiling need to be followed by CC=yourcompiler.

manodeep commented 7 years ago

Thanks for raising the issue! The compiler handling is now much better :)