search

manodeep / Corrfunc

⚡️⚡️⚡️Blazing fast correlation functions on the CPU.
https://corrfunc.readthedocs.io
MIT License
165 stars 50 forks source link

Link on RTD broken #145

Closed tmcclintock closed 6 years ago

tmcclintock commented 6 years ago

I think you need to rebuild your docs on RTD. From the current RTD page, I clicked on the "Edit on Github" link. This 404ed.

BTW hopefully you put out the paper soon so that I can properly cite you :).

manodeep commented 6 years ago

Thanks! Triggered a new build on rtd but the previous build was supposedly fine. Not sure what might be going on

As for the paper, one of the sad side-effects of becoming more senior is the severe lack of time to complete the millions of unfinished tasks :(. Just cite the ascl/ads entry for now - citations are getting picked up by ADS (or I just report them manually).

manodeep commented 6 years ago

I rebuilt the docs and the build passed again but the link is still broken.

I think the difference is that the bad link https://github.com/manodeep/Corrfunc/blob/origin/master/docs/source/index.rst has an extra reference to "origin", i.e., the good link should be https://github.com/manodeep/Corrfunc/blob/master/docs/source/index.rst

Looks like this is related to this issue

tmcclintock commented 6 years ago

Yea you are probably right. I'll close this since it looks like it's not Corrfunc specific.