Closed manodeep closed 6 years ago
@lgarrison While doing this, I noticed that this line checks for thetamin > 0.0
, but we don't really divide by thetamin anywhere -- so the check should really be thetamin >= 0.0
.
On a related issue, since we do allow for 0.0
as rmin
, then we should include your corrections for rmin == 0.0
, i.e., these lines. But none of the mocks pair-counters
currently have that correction included. Do you remember if there was any reason that we didn't include the correction for the mocks pair-counters
, or is that simple over-sight?
I guess it was just an oversight, although we never claimed in the documentation that self pairs are counted for the mocks. But for the consistency of the auto- and cross-correlation it seems like that should be the case.
I have a single bin in a file,
binfile
, but the file also contains a bunch of new-lines. When I runDDtheta_mocks
, the number of bins includes the total number of lines, and the output is fine for the first bin but really garbage for all next bins.This is because of a bug in the function
getnumlines
inutils.c
that does not strip off new-lines or white-space. The relevant comment within utils.c is:The patch would be: