search

manodeep / Corrfunc

⚡️⚡️⚡️Blazing fast correlation functions on the CPU.
https://corrfunc.readthedocs.io
MIT License
165 stars 50 forks source link

Added a gsl version [ci skip] #164

Closed manodeep closed 6 years ago

manodeep commented 6 years ago

In response to issue #163

astropy-bot[bot] commented 6 years ago

Hi there @manodeep :wave: - thanks for the pull request! I'm just a friendly :robot: that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part :smiley:.

Everything looks good from my point of view! :+1:

If there are any issues with this message, please report them here.

manodeep commented 6 years ago

@lgarrison Will you please take a look? Seems simple enough to be able to merge straight into master.

Not sure why the CI build failed -- restarted the tests

manodeep commented 6 years ago

Meant to request a review... :)

lgarrison commented 6 years ago

Do we need to add conda install libgfortran to the Python 2.6 test? E.g. https://github.com/ContinuumIO/anaconda-issues/issues/445

I don't think it's critical we solve this in the most robust way possible, since we're deprecating the Python 2.6 version in the next release anyway.

manodeep commented 6 years ago

@lgarrison Did you figure out how to resolve the astropy bot's comment?

lgarrison commented 6 years ago

Yes: rename CHANGELOG.rst to CHANGES.rst. It's implemented in #158, but I think we want to backport here as well.

manodeep commented 6 years ago

Oh my god - this bot is insistent. Hopefully, this is just initial pains; and comes with long-term gains in code quality.

Thanks so much @lgarrison for handling this changelog fixing

manodeep commented 6 years ago

I think technically the v2.1 release should really be called the v2.1.0

lgarrison commented 6 years ago

Okay, should we change the milestone? I think that's the only way to make the bot happy.

lgarrison commented 6 years ago

Also just noting that one needs 6 equal signs to delineate a section; see https://github.com/astropy/astropy-bot/blob/master/changebot/blueprints/changelog_helpers.py#L31.

manodeep commented 6 years ago

Yup - I agree about changing the milestone. Let me do that; do you mind reverting back to the previous changelog entry

manodeep commented 6 years ago

Good to squash merge?

lgarrison commented 6 years ago

Yeah. Technically Travis didn't check this, but everything after this build was changelog updates: https://travis-ci.org/manodeep/Corrfunc/builds/413307872