Closed manodeep closed 6 years ago
Hi there @manodeep :wave: - thanks for the pull request! I'm just a friendly :robot: that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part :smiley:.
Everything looks good from my point of view! :+1:
If there are any issues with this message, please report them here.
@lgarrison Will you please take a look? Seems simple enough to be able to merge straight into master.
Not sure why the CI build failed -- restarted the tests
Meant to request a review... :)
Do we need to add conda install libgfortran
to the Python 2.6 test? E.g. https://github.com/ContinuumIO/anaconda-issues/issues/445
I don't think it's critical we solve this in the most robust way possible, since we're deprecating the Python 2.6 version in the next release anyway.
@lgarrison Did you figure out how to resolve the astropy bot's comment?
Yes: rename CHANGELOG.rst
to CHANGES.rst
. It's implemented in #158, but I think we want to backport here as well.
Oh my god - this bot is insistent. Hopefully, this is just initial pains; and comes with long-term gains in code quality.
Thanks so much @lgarrison for handling this changelog fixing
I think technically the v2.1
release should really be called the v2.1.0
Okay, should we change the milestone? I think that's the only way to make the bot happy.
Also just noting that one needs 6 equal signs to delineate a section; see https://github.com/astropy/astropy-bot/blob/master/changebot/blueprints/changelog_helpers.py#L31.
Yup - I agree about changing the milestone. Let me do that; do you mind reverting back to the previous changelog entry
Good to squash merge?
Yeah. Technically Travis didn't check this, but everything after this build was changelog updates: https://travis-ci.org/manodeep/Corrfunc/builds/413307872
In response to issue #163