search

manodeep / Corrfunc

⚡️⚡️⚡️Blazing fast correlation functions on the CPU.
https://corrfunc.readthedocs.io
MIT License
165 stars 50 forks source link

Update countspheres_mocks_impl.c.src #168

Closed gbeltzmo closed 6 years ago

gbeltzmo commented 6 years ago

Moving free(xran);free(yran);free(zran); from line 405 to line 538 to resolve seg fault.

astropy-bot[bot] commented 6 years ago

Hi there @gbeltzmo :wave: - thanks for the pull request! I'm just a friendly :robot: that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part :smiley:.

Everything looks good from my point of view! :+1:

If there are any issues with this message, please report them here.

manodeep commented 6 years ago

@gbeltzmo Thanks for the PR!

I realize that there was over-sight on your OUR (oops, sorry!!) part and there is not an entry for the next release of Corrfunc -- v2.3.0. Will you please update the Changes.rst and include the following

2.3.0
=======

**Breaking Changes**
--------------------

New features
------------

Bug fixes
---------
- Fix segmentation fault in vpf_mocks (#150)
manodeep commented 6 years ago

@lgarrison I don't understand why the astropy-bot is unhappy. Do you know?

lgarrison commented 6 years ago

Yeah, I think the changelog entry needs the PR number instead of the issue number (and possibly in brackets instead of parentheses?).

manodeep commented 6 years ago

@gbeltzmo Will you please try out what @lgarrison said and see if the astropy-bot is happy...

If not, we will just merge in the PR, and fix it at our end. Thanks again @gbeltzmo

manodeep commented 6 years ago

@gbeltzmo The PR # is "168", ie replace (#150) with [#168] in Changes.rst.

manodeep commented 6 years ago

Un-related bug from numpy dependency is failing the build. Merging this in