manodeep / Corrfunc

⚡️⚡️⚡️Blazing fast correlation functions on the CPU.
https://corrfunc.readthedocs.io
MIT License
163 stars 50 forks source link

Starting development for v2.4 #182

Closed manodeep closed 5 years ago

pep8speaks commented 5 years ago

Hello @manodeep! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 33:19: E231 missing whitespace after ',' Line 84:37: E127 continuation line over-indented for visual indent Line 85:37: E127 continuation line over-indented for visual indent Line 86:37: E127 continuation line over-indented for visual indent Line 87:37: E127 continuation line over-indented for visual indent Line 88:37: E127 continuation line over-indented for visual indent Line 91:80: E501 line too long (82 > 79 characters) Line 92:80: E501 line too long (85 > 79 characters) Line 96:80: E501 line too long (82 > 79 characters) Line 97:80: E501 line too long (85 > 79 characters) Line 102:29: E128 continuation line under-indented for visual indent

Line 32:19: E231 missing whitespace after ',' Line 53:80: E501 line too long (80 > 79 characters) Line 57:80: E501 line too long (84 > 79 characters) Line 77:80: E501 line too long (87 > 79 characters) Line 78:80: E501 line too long (88 > 79 characters) Line 82:80: E501 line too long (82 > 79 characters) Line 84:80: E501 line too long (87 > 79 characters) Line 98:80: E501 line too long (88 > 79 characters) Line 99:80: E501 line too long (89 > 79 characters)

Line 47:25: W605 invalid escape sequence '\p' Line 123:80: E501 line too long (93 > 79 characters) Line 124:80: E501 line too long (80 > 79 characters) Line 180:80: E501 line too long (80 > 79 characters) Line 207:80: E501 line too long (80 > 79 characters) Line 232:26: W605 invalid escape sequence '\p' Line 344:80: E501 line too long (93 > 79 characters) Line 349:80: E501 line too long (88 > 79 characters) Line 373:80: E501 line too long (85 > 79 characters)

Line 28:30: W605 invalid escape sequence '\m' Line 41:44: W605 invalid escape sequence '\m' Line 43:37: W605 invalid escape sequence '\m' Line 62:80: E501 line too long (92 > 79 characters) Line 62:80: W605 invalid escape sequence '\L' Line 63:80: E501 line too long (94 > 79 characters) Line 63:81: W605 invalid escape sequence '\L' Line 80:43: W605 invalid escape sequence '\c' Line 80:65: W605 invalid escape sequence '\m' Line 85:25: W605 invalid escape sequence '\m' Line 234:62: W605 invalid escape sequence '\m' Line 251:80: E501 line too long (84 > 79 characters) Line 277:80: E501 line too long (93 > 79 characters) Line 282:80: E501 line too long (88 > 79 characters) Line 287:5: E303 too many blank lines (2) Line 307:80: E501 line too long (84 > 79 characters) Line 348:1: E305 expected 2 blank lines after class or function definition, found 1

Line 292:80: E501 line too long (93 > 79 characters) Line 319:7: E111 indentation is not a multiple of four

Line 12:71: E202 whitespace before ')'

Line 297:7: E111 indentation is not a multiple of four

Line 213:80: E501 line too long (91 > 79 characters) Line 218:80: E501 line too long (80 > 79 characters) Line 233:8: E111 indentation is not a multiple of four

Line 35:47: W605 invalid escape sequence '\p' Line 38:26: W605 invalid escape sequence '\p' Line 163:74: W605 invalid escape sequence '\p' Line 264:80: E501 line too long (91 > 79 characters) Line 269:80: E501 line too long (80 > 79 characters) Line 284:7: E111 indentation is not a multiple of four

Line 27:42: W605 invalid escape sequence '\m' Line 36:45: W605 invalid escape sequence '\m' Line 38:38: W605 invalid escape sequence '\m' Line 71:43: W605 invalid escape sequence '\c' Line 71:65: W605 invalid escape sequence '\m' Line 76:25: W605 invalid escape sequence '\m' Line 201:80: E501 line too long (97 > 79 characters) Line 203:80: E501 line too long (87 > 79 characters) Line 204:80: E501 line too long (91 > 79 characters) Line 280:80: E501 line too long (91 > 79 characters) Line 285:80: E501 line too long (80 > 79 characters) Line 307:80: E501 line too long (84 > 79 characters) Line 331:76: E231 missing whitespace after ','

Line 224:7: E111 indentation is not a multiple of four

Line 488:80: E501 line too long (84 > 79 characters) Line 507:7: E111 indentation is not a multiple of four

Line 199:80: E501 line too long (84 > 79 characters) Line 218:7: E111 indentation is not a multiple of four

Line 659:60: W291 trailing whitespace Line 898:80: E501 line too long (80 > 79 characters) Line 908:1: W293 blank line contains whitespace Line 912:58: W291 trailing whitespace Line 914:80: E501 line too long (98 > 79 characters) Line 916:80: E501 line too long (92 > 79 characters) Line 916:92: E502 the backslash is redundant between brackets Line 917:23: E128 continuation line under-indented for visual indent Line 921:1: W293 blank line contains whitespace Line 922:1: E302 expected 2 blank lines, found 1 Line 926:1: W293 blank line contains whitespace Line 962:80: E501 line too long (96 > 79 characters) Line 976:80: E501 line too long (83 > 79 characters) Line 986:15: E231 missing whitespace after ',' Line 1014:80: E501 line too long (122 > 79 characters) Line 1017:46: E231 missing whitespace after ',' Line 1020:46: E231 missing whitespace after ',' Line 1044:23: E231 missing whitespace after ':' Line 1045:23: E231 missing whitespace after ':' Line 1045:67: E202 whitespace before '}' Line 1054:5: E722 do not use bare 'except' Line 1056:1: W293 blank line contains whitespace

Line 69:32: E231 missing whitespace after ',' Line 135:80: E501 line too long (85 > 79 characters) Line 136:80: E501 line too long (87 > 79 characters) Line 140:80: E501 line too long (82 > 79 characters) Line 142:80: E501 line too long (87 > 79 characters)

Line 11:18: E701 multiple statements on one line (colon) Line 12:20: E701 multiple statements on one line (colon) Line 18:48: W291 trailing whitespace Line 34:44: W291 trailing whitespace Line 41:1: W293 blank line contains whitespace Line 52:1: W293 blank line contains whitespace Line 60:1: W293 blank line contains whitespace Line 75:1: W293 blank line contains whitespace Line 78:1: W293 blank line contains whitespace Line 95:5: E303 too many blank lines (2) Line 101:1: W293 blank line contains whitespace Line 110:29: W291 trailing whitespace Line 119:80: E501 line too long (82 > 79 characters) Line 121:48: W291 trailing whitespace Line 126:1: W293 blank line contains whitespace Line 130:44: W291 trailing whitespace Line 135:1: W293 blank line contains whitespace Line 136:1: W293 blank line contains whitespace Line 137:5: E303 too many blank lines (2) Line 138:1: W293 blank line contains whitespace Line 141:1: E303 too many blank lines (3) Line 144:1: W293 blank line contains whitespace Line 145:1: W293 blank line contains whitespace Line 145:1: W391 blank line at end of file

Line 372:1: W293 blank line contains whitespace Line 372:1: W391 blank line at end of file

Line 559:1: W293 blank line contains whitespace Line 559:1: W391 blank line at end of file

Line 450:5: E265 block comment should start with '# ' Line 451:5: E265 block comment should start with '# ' Line 452:5: E265 block comment should start with '# ' Line 454:5: E265 block comment should start with '# ' Line 484:80: E501 line too long (111 > 79 characters) Line 487:80: E501 line too long (110 > 79 characters) Line 533:80: E501 line too long (82 > 79 characters) Line 534:80: E501 line too long (86 > 79 characters) Line 535:80: E501 line too long (85 > 79 characters) Line 543:1: W293 blank line contains whitespace Line 544:80: E501 line too long (83 > 79 characters) Line 547:80: E501 line too long (84 > 79 characters) Line 549:1: W293 blank line contains whitespace Line 551:1: W293 blank line contains whitespace Line 591:28: E231 missing whitespace after ',' Line 595:33: E231 missing whitespace after ',' Line 599:29: E231 missing whitespace after ':' Line 599:46: E231 missing whitespace after ':' Line 599:61: E231 missing whitespace after ':' Line 599:80: E501 line too long (94 > 79 characters) Line 599:83: E231 missing whitespace after ':' Line 608:1: W293 blank line contains whitespace Line 627:80: E501 line too long (85 > 79 characters) Line 629:80: E501 line too long (86 > 79 characters) Line 630:1: W293 blank line contains whitespace Line 632:1: W293 blank line contains whitespace Line 636:80: E501 line too long (110 > 79 characters)

Line 158:80: E501 line too long (92 > 79 characters) Line 179:80: E501 line too long (96 > 79 characters) Line 200:80: E501 line too long (92 > 79 characters) Line 220:80: E501 line too long (92 > 79 characters) Line 424:5: E265 block comment should start with '# ' Line 425:5: E265 block comment should start with '# ' Line 426:5: E265 block comment should start with '# ' Line 428:5: E265 block comment should start with '# ' Line 455:80: E501 line too long (108 > 79 characters) Line 458:80: E501 line too long (107 > 79 characters) Line 505:80: E501 line too long (82 > 79 characters) Line 506:80: E501 line too long (86 > 79 characters) Line 507:80: E501 line too long (85 > 79 characters) Line 508:29: E117 over-indented (comment) Line 515:1: W293 blank line contains whitespace Line 516:80: E501 line too long (83 > 79 characters) Line 519:80: E501 line too long (84 > 79 characters) Line 533:16: E225 missing whitespace around operator Line 562:33: E231 missing whitespace after ',' Line 564:34: E231 missing whitespace after ',' Line 568:30: E231 missing whitespace after ',' Line 569:30: E231 missing whitespace after ',' Line 571:33: E231 missing whitespace after ',' Line 573:34: E231 missing whitespace after ',' Line 576:29: E231 missing whitespace after ':' Line 576:46: E231 missing whitespace after ':' Line 576:61: E231 missing whitespace after ':' Line 576:80: E501 line too long (94 > 79 characters) Line 576:83: E231 missing whitespace after ':' Line 596:5: E303 too many blank lines (2) Line 602:80: E501 line too long (98 > 79 characters) Line 607:80: E501 line too long (104 > 79 characters) Line 613:80: E501 line too long (99 > 79 characters) Line 614:1: W293 blank line contains whitespace Line 618:1: W293 blank line contains whitespace Line 622:80: E501 line too long (110 > 79 characters)

Line 60:20: E128 continuation line under-indented for visual indent Line 171:80: E501 line too long (84 > 79 characters) Line 306:5: E303 too many blank lines (2) Line 306:36: E231 missing whitespace after ','

Line 16:36: E231 missing whitespace after ','

Line 194:19: E231 missing whitespace after ',' Line 298:80: E501 line too long (82 > 79 characters) Line 299:80: E501 line too long (85 > 79 characters) Line 303:80: E501 line too long (82 > 79 characters) Line 304:80: E501 line too long (85 > 79 characters)

manodeep commented 5 years ago

Rather than trying to merge on the github interface, I will merge master into develop locally and then start working on v2.4