search

manodeep / Corrfunc

⚡️⚡️⚡️Blazing fast correlation functions on the CPU.
https://corrfunc.readthedocs.io
MIT License
163 stars 50 forks source link

Fix convert endian bug #191

Closed Christopher-Bradshaw closed 4 years ago

Christopher-Bradshaw commented 4 years ago

See https://github.com/manodeep/Corrfunc/issues/190 for context.

Let me know if there is anything else to do here. I think it should be good to go, but will check back in later to make sure tests passed.

pep8speaks commented 4 years ago

Hello @Christopher-Bradshaw! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-07-31 01:12:28 UTC
manodeep commented 4 years ago

Thanks a lot for the fix!

(Not sure why the notifications says I deleted comments...seems strange)

Christopher-Bradshaw commented 4 years ago

@manodeep I think codacy-bot deletes its comments when you fix the things. And I'm guessing you gave it a key registered to you so github thinks it looks like you? Bit odd though...

Anyway, thanks for the merge, will confirm that it works now