manodeep / Corrfunc

⚡️⚡️⚡️Blazing fast correlation functions on the CPU.
https://corrfunc.readthedocs.io
MIT License
165 stars 50 forks source link

Incorrect install location for package data #207

Open manodeep opened 4 years ago

manodeep commented 4 years ago

General information

Issue description

The files needed for Corrfunc tests are located in theory/tests/ and mocks/tests/. Both these directories and the contained files need to be packaged in the source distribution to allow users to validate their install. However, these two directories are unexpectedly outside of the package root.

Expected behavior

Files should all be contained within package root directory.

Actual behaviour

The theory/ and mocks directory are created directly under site-packages.

What have you tried so far?

Modifying setup.py in all kinds of ways but nothing has succeeded so far.

Note The behaviour is different when installing with python setup.py install. The theory and mocks directories are then installed under site-packages/Corrfunc-<version>-py<ver>-macosx-<osx_ver>-x86_64.egg/.

Minimal failing example

Install Corrfunc with pip and then navigate to the relevant site-packages directory. There will be two directories -- theory/ and mocks/, that should not exist at that level. Uninstalling Corrfunc also leaves behind those two folders (all the contained files are deleted thankfully).

Installing with python setup.py install does not create this spill.